Guard benchmark summary against zero-time compare ratios#219
Closed
Copilot wants to merge 3 commits into
Closed
Conversation
Copilot
AI
changed the title
[WIP] Fix code for all comments in review thread
Guard benchmark summary against zero-time compare ratios
Jun 29, 2026
tameware
requested changes
Jun 29, 2026
tameware
left a comment
Collaborator
There was a problem hiding this comment.
Skip this change. If need be, we'll update timer.cpp instead.
Copilot stopped work on behalf of
tameware due to an error
June 29, 2026 12:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the remaining
benchmark.shreview-thread issue in PR #217. The compare summary could divide by zero when the branch average rounded to0, breaking output for very small runs.Summary ratio handling
cmp/branchcomputation whenbranch_avg == 0infwhen compare is non-zero and branch rounds to zeron/awhen both sides round to zeroSummary labeling
branch ~0msScope
awkblock inbenchmark.sh